[all-commits] [llvm/llvm-project] b84ac9: [clang][dataflow] Fix bug in handling of reference...

[Yitzhak Mandelbaum via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b84ac96a35c72420b45db6385f83a5e0c516349f
      https://github.com/llvm/llvm-project/commit/b84ac96a35c72420b45db6385f83a5e0c516349f
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/Transfer.cpp
    M clang/unittests/Analysis/FlowSensitive/TransferTest.cpp

  Log Message:
  -----------
  [clang][dataflow] Fix bug in handling of reference-typed fields.

This patch fixes a subtle bug in how we create lvalues to reference-typed
fields. In the rare case that the field is umodeled because of the depth limit
on field modeling, the lvalue created can be malformed. This patch prevents that
and adds some related assertions to other code dealing with lvalues for
references.

Differential Revision: https://reviews.llvm.org/D142468