[all-commits] [llvm/llvm-project] f1d3bc: [CMake] Replace list(FIND) by if(IN_LIST) where in...

Aaron Puchert via All-commits all-commits at lists.llvm.org
Mon Jan 23 14:59:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1d3bc49634cfefe35de3aa631cef9f808b12896
      https://github.com/llvm/llvm-project/commit/f1d3bc49634cfefe35de3aa631cef9f808b12896
  Author: Aaron Puchert <aaronpuchert at alice-dsl.net>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M llvm/cmake/config-ix.cmake
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/cmake/modules/AddSphinxTarget.cmake
    M llvm/cmake/modules/ChooseMSVCCRT.cmake
    M llvm/cmake/modules/LLVM-Config.cmake
    M llvm/cmake/modules/LLVMExternalProjectUtils.cmake
    M llvm/cmake/modules/LLVMProcessSources.cmake
    M llvm/cmake/modules/TableGen.cmake

  Log Message:
  -----------
  [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used

If we don't use the index otherwise, if(IN_LIST) is more readable and
doesn't clutter the local scope with index variables.

This was pointed out by @beanz in D96670.

Reviewed By: beanz

Differential Revision: https://reviews.llvm.org/D142405




More information about the All-commits mailing list