[all-commits] [llvm/llvm-project] 391483: [mlir][MemRefToLLVM] Remove the code for lowering ...

qcolombet via All-commits all-commits at lists.llvm.org
Mon Jan 23 07:48:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3914836273aa51f14121abd77cc6986cd3ccee11
      https://github.com/llvm/llvm-project/commit/3914836273aa51f14121abd77cc6986cd3ccee11
  Author: Quentin Colombet <quentin.colombet at gmail.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
    M mlir/test/Conversion/MemRefToLLVM/expand-then-convert-to-llvm.mlir
    M mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-collapse-tensor.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-expand-tensor.mlir

  Log Message:
  -----------
  [mlir][MemRefToLLVM] Remove the code for lowering collaspe/expand_shape

collapse/expand_shape are supposed to be expanded before we hit the
lowering code.
The expansion is done with the pass called expand-strided-metadata.

This patch is NFC in spirit but not in practice because
expand-strided-metadata won't try to accomodate for "invalid" strides
for dynamic sizes that are 1 at runtime.

The previous code was broken in that respect too, but differently: it
handled only the case of row-major layouts.
That whole part is being reworked separately.

Differential Revision: https://reviews.llvm.org/D136483




More information about the All-commits mailing list