[all-commits] [llvm/llvm-project] 91b9c0: [mlir] fix outdated assert in affine symbol verifi...

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 91b9c0cd6b9f9bae0753bf7e41188a55a5ee1dfb
      https://github.com/llvm/llvm-project/commit/91b9c0cd6b9f9bae0753bf7e41188a55a5ee1dfb
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M mlir/lib/Dialect/Affine/IR/AffineOps.cpp
    M mlir/test/Dialect/Affine/invalid.mlir

  Log Message:
  -----------
  [mlir] fix outdated assert in affine symbol verification

The verification of affine value classification for symbols was
expecting, incorrectly, that the dimension operand of `memref.dim` was
being produced by a constant-like operation. This is legacy of the
dimension being an attribute originally, and was never updated after it
was switched to be an operation. Treat such cases conservatively and
classify the value as non-symbol.

A more advanced version could attempt to check that the value would be a
valid symbol for all possible values the dimension attribute could take,
but this does not seem immediately useful.

Fixes #59993.

Reviewed By: bondhugula

Differential Revision: https://reviews.llvm.org/D142204