[all-commits] [llvm/llvm-project] d10adf: [NFC][SCEV] `createNodeForSelectOrPHIInstWithICmpI...

[Roman Lebedev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d10adf614296849c6028cf1e0bc43204267564b4
      https://github.com/llvm/llvm-project/commit/d10adf614296849c6028cf1e0bc43204267564b4
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/ScalarEvolution.h
    M llvm/lib/Analysis/ScalarEvolution.cpp

  Log Message:
  -----------
  [NFC][SCEV] `createNodeForSelectOrPHIInstWithICmpInstCond()`: return optional

We only want about the result if it succeeds, and don't want `SCEVUnknown`.


  Commit: aa121336377fe17b07e8edd1d48a20e655183581
      https://github.com/llvm/llvm-project/commit/aa121336377fe17b07e8edd1d48a20e655183581
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/ScalarEvolution.h
    M llvm/lib/Analysis/ScalarEvolution.cpp

  Log Message:
  -----------
  [NFC][SCEV] `createNodeForSelectOrPHIInstWithICmpInstCond()`: directly take `Type`, not `Instruction`

We don't use the `Instruction` itself, only it's type anyways.


  Commit: b0ef5a82e9aa5076b117c4122a95669f63b81876
      https://github.com/llvm/llvm-project/commit/b0ef5a82e9aa5076b117c4122a95669f63b81876
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/ScalarEvolutionExpressions.h

  Log Message:
  -----------
  [NFC][SCEV] `SCEVTraversal::visitAll()`: deduplicate handling

They don't not do anything different from what we do for n-ary expressions,
there is no point in special-casing them.


  Commit: 1f4f55de5a16f6fed8970b4aa63e84ef74af82d3
      https://github.com/llvm/llvm-project/commit/1f4f55de5a16f6fed8970b4aa63e84ef74af82d3
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M llvm/lib/Analysis/ScalarEvolution.cpp

  Log Message:
  -----------
  [NFC][SCEV] `CompareSCEVComplexity`: deduplicate handling

For all but unknown/constant/recurrences, the handling is identical,
there is no point in special-casing anything.


Compare: https://github.com/llvm/llvm-project/compare/6aaac4c14457...1f4f55de5a16