[all-commits] [llvm/llvm-project] e12a95: Remove the LINK_COMPONENTS entry from lldb-instr C...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73
      https://github.com/llvm/llvm-project/commit/e12a950d90f88aeddaa97d6e7c8fd0bfedc42f73
  Author: Jim Ingham <jingham at apple.com>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M lldb/tools/lldb-instr/CMakeLists.txt

  Log Message:
  -----------
  Remove the LINK_COMPONENTS entry from lldb-instr CMakery

The presence of this entry causes the Xcode generator to produce
two references to libLLVMSupport.a, one at the end of the list, and
that causes the build to fail with a link error.  The first version
was pulled in when processing the CLANG_LIBS entries in the
lldb/tools/lldb-instr/CMakeLists.txt.

I looked around and the only places where we use LINK_COMPONENTS and
CLANG_LIBS together are various lldb subdirectories that produce .a
files but don't actually link anything.

Anyway, this line doesn't seem to be needed for either the regular
Ninja or the Xcode generator, and removing it makes the xcode build
work again.

Differential Revision: https://reviews.llvm.org/D142241