[all-commits] [llvm/llvm-project] 255922: [OpenMP] Clean up AMD handling for `-fopenmp-targe...

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Jan 20 15:34:11 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 255922be7f008362bae16c708a2d90f60b4aba35
      https://github.com/llvm/llvm-project/commit/255922be7f008362bae16c708a2d90f60b4aba35
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
    M clang/test/Driver/amdgpu-openmp-system-arch-fail.c

  Log Message:
  -----------
  [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

Previously we had some special handling here that errored out if
multiple architectures were detected. This isn't a problem anymore as
the runtime can handle multi-archicture binaries automatically. So it's
safe to simply take the first architecture that we know works. If users
use `--offload-arch=native` instead it will build for all the
architectures at the same time rather than just picking one. This patch
makes it consisten with the NVPTX version.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D142138




More information about the All-commits mailing list