[all-commits] [llvm/llvm-project] c3efd5: [clang][modules] Disallow importing private framew...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Fri Jan 20 13:38:18 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c3efd52770ca964ba46287298c1d2f7697fd446c
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M clang/include/clang/Basic/Module.h
    M clang/lib/Basic/Module.cpp
    M clang/lib/Lex/PPDirectives.cpp
    M clang/lib/Sema/SemaModule.cpp
    A clang/test/Modules/implementation-of-module-private.m

  Log Message:
  [clang][modules] Disallow importing private framework in the implementation

Whenever we are compiling implementation of a framework (with the `-fmodule-name=FW` option), we never translate `#import <FW/Header.h>` to an import, regardless of whether "Header.h" belongs to "FW" or "FW_Private". For the same reasons, we also disallow `@import FW`. However, we still allow `@import FW_Private`. This patch disallows that a well, to be consistent with the rest of the rules.

Reviewed By: benlangmuir

Differential Revision: https://reviews.llvm.org/D142167

More information about the All-commits mailing list