[all-commits] [llvm/llvm-project] 4ece50: [Assignment Tracking][NFC] Replace LLVM command li...

Orlando Cazalet-Hyams via All-commits all-commits at lists.llvm.org
Fri Jan 20 06:25:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ece50737d5385fb80cfa23f5297d1111f8eed39
      https://github.com/llvm/llvm-project/commit/4ece50737d5385fb80cfa23f5297d1111f8eed39
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2023-01-20 (Fri, 20 Jan 2023)

  Changed paths:
    M clang/lib/Driver/ToolChains/Clang.cpp
    R clang/test/Driver/assignment-tracking-opts.c
    M llvm/docs/AssignmentTracking.md
    M llvm/include/llvm/IR/DebugInfo.h
    M llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
    M llvm/lib/Transforms/Utils/InlineFunction.cpp
    M llvm/test/DebugInfo/Generic/assignment-tracking/adce/no-delete.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/codegenprepare/sunk-addr.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/dse/dse-after-memcpyopt-merge.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/dse/shorten.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/inline/id.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/inline/inline-stores.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/inline/use-before-def.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/alloca-bitcast.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/memset.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/remove-redundant-dbg.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/sink-store.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/sink.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/storemerge.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/licm/merge.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/licm/multi-exit.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/loop-deletion/dead-loop.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/mem2reg/phi.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/mem2reg/single-block-alloca.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/mem2reg/single-store-alloca.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/memcpyopt/merge-stores.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/mldst-motion/diamond.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/distinct.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/instruction-type.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/operands.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/roundtrip.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/verify.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/remove-redundant-fwd-scan-linked.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/remove-redundant.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/salvage-value.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/simplifycfg/empty-block.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/simplifycfg/speculated-store.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/slp-vectorizer/merge-scalars.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/after-inlining.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/alloca-single-slice.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/complex.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/frag-2.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/frag.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/id.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/memcpy.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/memmove-to-from-same-alloca.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/rewrite.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/store.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/user-memcpy.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/vec-1.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/vec-2.ll
    M llvm/test/DebugInfo/Generic/assignment-tracking/track-assignments.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/DSE.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/dbg-phi-produces-undef.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/diamond-1.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/diamond-2.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/diamond-3.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/loop-hoist.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/loop-sink.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/loop-unroll.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/lower-offset-expression.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/lower-to-value.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/mem-loc-frag-fill-cfg.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/mem-loc-frag-fill.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/nested-loop-frags.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/nested-loop-sroa.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/nested-loop.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/no-redundant-def-after-alloca.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/order-of-defs.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/remove-redundant-defs-to-prevent-reordering.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/sdag-dangling-dbgassign.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/sdag-ir-salvage-assign.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/sdag-transfer-dbgassign.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/single-memory-location-2.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/single-memory-location.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/split-alloca.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/untagged-store-frag.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/use-known-value-at-early-mem-def-2.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/use-known-value-at-early-mem-def.ll

  Log Message:
  -----------
  [Assignment Tracking][NFC] Replace LLVM command line option with a module flag

Remove LLVM flag -experimental-assignment-tracking. Assignment tracking is
still enabled from Clang with the command line -Xclang
-fexperimental-assignment-tracking which tells Clang to ask LLVM to run the
pass declare-to-assign. That pass converts conventional debug intrinsics to
assignment tracking metadata. With this patch it now also sets a module flag
debug-info-assignment-tracking with the value `i1 true` (using the flag conflict
rule `Max` since enabling assignment tracking on IR that contains only
conventional debug intrinsics should cause no issues).

Update the docs and tests too.

Reviewed By: CarlosAlbertoEnciso

Differential Revision: https://reviews.llvm.org/D142027




More information about the All-commits mailing list