[all-commits] [llvm/llvm-project] af9a45: [llvm][codegen] Fix non-determinism in StackFrameL...

Paul Kirth via All-commits all-commits at lists.llvm.org
Thu Jan 19 12:04:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: af9a452e57554c2c5e876986e33c2a75314259e8
      https://github.com/llvm/llvm-project/commit/af9a452e57554c2c5e876986e33c2a75314259e8
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    M llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp
    M llvm/test/CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll

  Log Message:
  -----------
  [llvm][codegen] Fix non-determinism in StackFrameLayoutAnalysisPass output

We were iterating over a SmallPtrSet when outputting slot variables.
This is still correct but made the test fail under reverse iteration.
This patch replaces the SmallPtrSet with a SmallVector.

Also remove the "Stack Frame Layout" lines from arm64-opt-remarks-lazy-bfi test,
since those also break under reverse iteration.

Reviewed By: nickdesaulniers

Differential Revision: https://reviews.llvm.org/D142127




More information about the All-commits mailing list