[all-commits] [llvm/llvm-project] a0f8bd: [lit] Stop supporting triple substrings in UNSUPPO...

Paul T Robinson via All-commits all-commits at lists.llvm.org
Thu Jan 19 08:35:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a0f8bdbb18a82ec150515d24f6eefb3519d4459a
      https://github.com/llvm/llvm-project/commit/a0f8bdbb18a82ec150515d24f6eefb3519d4459a
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2023-01-19 (Thu, 19 Jan 2023)

  Changed paths:
    M llvm/docs/ReleaseNotes.rst
    M llvm/utils/lit/lit/BooleanExpression.py
    M llvm/utils/lit/lit/Test.py

  Log Message:
  -----------
  [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL

AFAICT all in-tree lit tests have been converted to use `target=...`
and so there is no longer any need for triples being special.
Some project config files still define their own features based on
the triple, but those are normal feature words (although now are
redundant with target= checks).

Downstream tests that use triple substrings will need to convert.
For example:
    UNSUPPORTED: -aix
    XFAIL: arm
becomes
    UNSUPPORTED: target={{.*}}-aix{{.*}}
    XFAIL: target=arm{{.*}}

You can do
    git log --grep "special handling for triples"
to find many examples of updates to the upstream tests.

https://discourse.llvm.org/t/rfc-lits-requires-and-triples/66041

Differential Revision: https://reviews.llvm.org/D141007




More information about the All-commits mailing list