[all-commits] [llvm/llvm-project] ea0eee: [Libomptarget] Only build GPU tests if a GPU is fo...
Joseph Huber via All-commits
all-commits at lists.llvm.org
Wed Jan 18 08:35:53 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: ea0eee80d8988d16133bcb858874a1d95ede1a32
https://github.com/llvm/llvm-project/commit/ea0eee80d8988d16133bcb858874a1d95ede1a32
Author: Joseph Huber <jhuber6 at vols.utk.edu>
Date: 2023-01-18 (Wed, 18 Jan 2023)
Changed paths:
M openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake
M openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
M openmp/libomptarget/plugins/cuda/CMakeLists.txt
Log Message:
-----------
[Libomptarget] Only build GPU tests if a GPU is found on the system
Currently we build tests as long as the libraries are found on the
machine. This doesn't necessarily mean there is a GPU to use though.
This patch changes it to where we only will build the tests if we found
a compatible GPU via `nvptx-arch` or `amdgpu-arch`.
The only downside to this I could see if someone were to build LLVM on a
home node of a cluster and then wished to run the tests after switching
to a compute node. For this I think we should allow it to be overridden.
I think that's better than allowing us to run tests that will fail by
default.
Reviewed By: tianshilei1992
Differential Revision: https://reviews.llvm.org/D142018
More information about the All-commits
mailing list