[all-commits] [llvm/llvm-project] feee22: [VPlan] Disconnect VPRegionBlock from successors i...

Florian Hahn via All-commits all-commits at lists.llvm.org
Wed Jan 18 07:03:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: feee22db52259d19a8624318517ef5688abfc67c
      https://github.com/llvm/llvm-project/commit/feee22db52259d19a8624318517ef5688abfc67c
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/VPlanCFG.h
    M llvm/unittests/Transforms/Vectorize/VPlanTest.cpp

  Log Message:
  -----------
  [VPlan] Disconnect VPRegionBlock from successors in graph iterator(NFCI)

This updates the VPAllSuccessorsIterator to not connect the
VPRegionBlock itself to its successors. The successors are connected to
the exit block of the region. At the moment, this doesn't change any
exisint functionality.

But the new schema ensures the following property when used for
VPDominatorTree:

1. Entry & exit blocks of regions dominate the successors of the region.

This allows for convenient checking of dominance between defs and uses
that are not defined in the same region. I will share a follow-up patch
to use it for the VPDominatorTree soon.

Depends on D140500.

Reviewed By: Ayal

Differential Revision: https://reviews.llvm.org/D140511




More information about the All-commits mailing list