[all-commits] [llvm/llvm-project] f3f4bc: [NFC] [scudo] syntax-check DCHECK arguments if DCH...

[Florian Mayer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3f4bc814bfe1131f7ab30eed03a825bf47521ea
      https://github.com/llvm/llvm-project/commit/f3f4bc814bfe1131f7ab30eed03a825bf47521ea
  Author: Florian Mayer <fmayer at google.com>
  Date:   2023-01-17 (Tue, 17 Jan 2023)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/internal_defs.h

  Log Message:
  -----------
  [NFC] [scudo] syntax-check DCHECK arguments if DCHECK is off

This is a widespread technique, used in at least:

* ABSL: https://github.com/abseil/abseil-cpp/blob/master/absl/log/internal/check_op.h#L52
* Chromium: https://source.chromium.org/chromium/chromium/src/+/main:base/check.h;l=185?q=DCHECK%20f:base&ss=chromium
* Android: https://cs.android.com/android/platform/superproject/+/master:system/libbase/include/android-base/logging.h;drc=bda7f0a0cc945c860713a1dc497919f17fad1651;l=321

Reviewed By: Chia-hungDuan, vitalybuka

Differential Revision: https://reviews.llvm.org/D141713