[all-commits] [llvm/llvm-project] 5898be: [mlgo] Remove the protobuf dependency

Mircea Trofin via All-commits all-commits at lists.llvm.org
Tue Jan 17 13:12:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5898be19e66d97662e9d87c526105c6ebd961cba
      https://github.com/llvm/llvm-project/commit/5898be19e66d97662e9d87c526105c6ebd961cba
  Author: Mircea Trofin <mtrofin at google.com>
  Date:   2023-01-17 (Tue, 17 Jan 2023)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/TensorFlowCompile.cmake
    M llvm/include/llvm/Analysis/Utils/TrainingLogger.h
    M llvm/lib/Analysis/CMakeLists.txt
    M llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
    M llvm/lib/Analysis/TrainingLogger.cpp
    M llvm/test/CodeGen/MLRegalloc/Inputs/reference-log-noml.txt
    M llvm/test/CodeGen/MLRegalloc/Inputs/reference-prio-log-noml.txt
    M llvm/test/CodeGen/MLRegalloc/dev-mode-extra-features-logging.ll
    M llvm/test/CodeGen/MLRegalloc/dev-mode-log-2-fcts.ll
    M llvm/test/CodeGen/MLRegalloc/dev-mode-logging.ll
    M llvm/test/CodeGen/MLRegalloc/dev-mode-prio-logging.ll
    M llvm/test/Transforms/Inline/ML/bounds-checks-rewards.ll
    M llvm/test/Transforms/Inline/ML/dev-mode-log-deleted.ll
    M llvm/test/Transforms/Inline/ML/development-training-log.ll
    M llvm/test/Transforms/Inline/ML/ml-test-development-mode.ll
    M llvm/unittests/Analysis/CMakeLists.txt
    R llvm/unittests/Analysis/TrainingLoggerTest.cpp

  Log Message:
  -----------
  [mlgo] Remove the protobuf dependency

The dependency was due to the log format. This change switches to the
previously-introduced (D139370) "dependency-free" logger instead of the
protobuf-based one.

A subsequent change will clean out the unnecessary abstraction left
behind.

This change drops the logger unittest, we have sufficient test coverage
via lit tests, and a unit test would require adding, unnecesarily, a log
reader (the reader is expected to be python, for the ML side, and there
is a reader for that under Analysis/models, used for tests).

Differential Revision: https://reviews.llvm.org/D141720




More information about the All-commits mailing list