[all-commits] [llvm/llvm-project] ffd3a1: Fix crash in Spirv -lower-host-to-llvm pass

Mehdi Amini via All-commits all-commits at lists.llvm.org
Mon Jan 16 13:07:17 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ffd3a19e653f9356ec0be65d4e1c38562573f6c7
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
    A mlir/test/Conversion/SPIRVToLLVM/lower-host-to-llvm-calls_fail.mlir

  Log Message:
  Fix crash in Spirv -lower-host-to-llvm pass

When providing with a spirv module as input where no conversion happens
the code didn't defend against broken invariant.

We'll fail the pass here, but it's not clear if it is the right thing
or if the module should just be ignored.

Fixes #59971

Reviewed By: kuhar

Differential Revision: https://reviews.llvm.org/D141856

More information about the All-commits mailing list