[all-commits] [llvm/llvm-project] b3d863: [mlir][llvmir] Fixed MDNode uniquing during TBAA t...

Slava Zakharin via All-commits all-commits at lists.llvm.org
Mon Jan 16 12:50:57 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b3d8639f3536a4876b511aca9fb7948ff9266cee
      https://github.com/llvm/llvm-project/commit/b3d8639f3536a4876b511aca9fb7948ff9266cee
  Author: Slava Zakharin <szakharin at nvidia.com>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    M mlir/test/Target/LLVMIR/tbaa.mlir

  Log Message:
  -----------
  [mlir][llvmir] Fixed MDNode uniquing during TBAA translation.

In the process of creating the MDNodes for the TBAA tag operations
we used to produce incomplete MDNodes like:
```
  @__tbaa::@tbaa_tag_4 => !{!null, !null, i64 0}
  @__tbaa::@tbaa_tag_7 => !{!null, !null, i64 0}
```
This caused the two tags to map to the same incomplete MDNode due to uniquing.
To prevent this, we have to use temporary MDNodes instead of !null's.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D141726




More information about the All-commits mailing list