[all-commits] [llvm/llvm-project] f6ace2: [amdgpu-arch] Dynamically load the HSA runtime if ...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Jan 16 11:14:03 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f6ace23172e5930be0e7cc602f50e1e9c54d7a9a
      https://github.com/llvm/llvm-project/commit/f6ace23172e5930be0e7cc602f50e1e9c54d7a9a
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M clang/tools/amdgpu-arch/AMDGPUArch.cpp
    M clang/tools/amdgpu-arch/CMakeLists.txt

  Log Message:
  -----------
  [amdgpu-arch] Dynamically load the HSA runtime if not found during the build

We use the `amdgpu-arch` tool to query the installed GPUs at runtime.
One problem is that this tool is currently not build if the person
building the LLVM binary does not have the HSA runtime on their system.
This means that if someone built and distrubted an installation of LLVM
without HSA, then the user will not be able to use it even if they have
it on their system.

This patch makes us build this tool unconditionally and adds extra logic
to dynamically load HSA if it's present.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D141859


  Commit: 9954516ffb10a39ae0c8517f4865eec24e07d56e
      https://github.com/llvm/llvm-project/commit/9954516ffb10a39ae0c8517f4865eec24e07d56e
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-01-16 (Mon, 16 Jan 2023)

  Changed paths:
    M clang/tools/nvptx-arch/CMakeLists.txt
    M clang/tools/nvptx-arch/NVPTXArch.cpp

  Log Message:
  -----------
  [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

Much like the changes in D141859, this patch allows the `nvptx-arch`
tool to be built and provided with every distrubition of LLVM / Clang.
This will make it more reliable for our toolchains to depend on. The
changes here configure a version that dynamically loads CUDA if it was
not found at build time.

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D141861


Compare: https://github.com/llvm/llvm-project/compare/a8be1a3dd3b6...9954516ffb10


More information about the All-commits mailing list