[all-commits] [llvm/llvm-project] 5be389: Revert "[InstCombine] Add test coverage for (icmp ...

Craig Topper via All-commits all-commits at lists.llvm.org
Sat Jan 14 00:39:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5be3894b608420e78e53be13ac9bb4278d3273d4
      https://github.com/llvm/llvm-project/commit/5be3894b608420e78e53be13ac9bb4278d3273d4
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-01-14 (Sat, 14 Jan 2023)

  Changed paths:
    M llvm/test/Transforms/InstCombine/icmp.ll

  Log Message:
  -----------
  Revert "[InstCombine] Add test coverage for (icmp slt/sge (1 << Y), 0). NFC"

This reverts commit e25f2287dd7d6854b0bbfb9878fecdbbad21038d.

I messed up the predicates in the description.


  Commit: bb83dc10f5e7aece86a0ad2158cfd28d1611f336
      https://github.com/llvm/llvm-project/commit/bb83dc10f5e7aece86a0ad2158cfd28d1611f336
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-01-14 (Sat, 14 Jan 2023)

  Changed paths:
    M llvm/test/Transforms/InstCombine/icmp.ll

  Log Message:
  -----------
  [InstCombine] Add test coverage for (icmp sgt/sle (1 << Y), 0). NFC"

We already optimize the sgt case to (icmp ne Y, BitWidth-1), but
we miss optimizing sle because it canonicalizes to (icmp slt (1 << X), 1)
first.


Compare: https://github.com/llvm/llvm-project/compare/e25f2287dd7d...bb83dc10f5e7


More information about the All-commits mailing list