[all-commits] [llvm/llvm-project] 347028: [clang] Report the on-disk paths for inputs to mod...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Fri Jan 13 18:38:44 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 347028a4d8da8aa1ae311c95424999fcd31d98cb
      https://github.com/llvm/llvm-project/commit/347028a4d8da8aa1ae311c95424999fcd31d98cb
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-01-13 (Fri, 13 Jan 2023)

  Changed paths:
    M clang/lib/Frontend/DependencyFile.cpp
    M clang/lib/Frontend/ModuleDependencyCollector.cpp
    A clang/test/Modules/dependency-gen-vfs.c

  Log Message:
  -----------
  [clang] Report the on-disk paths for inputs to module compiles

Since D135636, PCM files contain the "as requested" path of input files. The machinery for generating dependency files reports those paths as they appeared in the PCM file, which may confuse consumers that are not aware of VFS overlays that might've been in place at compile-time.

This patch makes sure the "use-external-name" setting is being respected when generating dependency files in modular builds by piping the paths serialized in PCMs through `FileEntryRef::getName()` before putting them into dependency files.

rdar://103459532

Reviewed By: benlangmuir

Differential Revision: https://reviews.llvm.org/D141644




More information about the All-commits mailing list