[all-commits] [llvm/llvm-project] 5ffa8c: [NFC][DAGCombiner] Fix typo in `visitFREEZE()`

Zhang via All-commits all-commits at lists.llvm.org
Fri Jan 13 10:54:09 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ffa8c401968be7eb950a3ed186dff2e7ce1ab9e
      https://github.com/llvm/llvm-project/commit/5ffa8c401968be7eb950a3ed186dff2e7ce1ab9e
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2023-01-13 (Fri, 13 Jan 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  -----------
  [NFC][DAGCombiner] Fix typo in `visitFREEZE()`


  Commit: 95414345d54ea714aceafb125541555ece31e876
      https://github.com/llvm/llvm-project/commit/95414345d54ea714aceafb125541555ece31e876
  Author: HanSheng Zhang <admin at mayuyu.io>
  Date:   2023-01-13 (Fri, 13 Jan 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    A llvm/test/CodeGen/AArch64/pr59891-dagcombine-deleted-freeze.ll

  Log Message:
  -----------
  [DAGCombiner] `visitFREEZE()`: gracefully handle node invalidation

When we freeze operands of an operation that we are trying to freeze,
doing so may invalidate the original SDValue. We should just re-fetch
it from the ISD::FREEZE node, because if we bail, we'd hopefully just
revisit the node and do that again.

Fixes https://github.com/llvm/llvm-project/issues/59891

Differential Revision: https://reviews.llvm.org/D141256


Compare: https://github.com/llvm/llvm-project/compare/c3c6d47c45bc...95414345d54e


More information about the All-commits mailing list