[all-commits] [llvm/llvm-project] 537c60: [mlir][AttrType] Emit unbalanced character errors ...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 537c6016c5855614d12c9ae35032b7bb0fd4f57b
      https://github.com/llvm/llvm-project/commit/537c6016c5855614d12c9ae35032b7bb0fd4f57b
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M mlir/lib/AsmParser/DialectSymbolParser.cpp
    M mlir/test/Dialect/SPIRV/IR/types.mlir
    M mlir/test/IR/invalid.mlir

  Log Message:
  -----------
  [mlir][AttrType] Emit unbalanced character errors using the last punctuation used

This gives a better diagnostic in general, because it indicates that the user didn't
close out the last open puncutation range. For example:

```
foo.op {
  some.op -> !blah.pointer<
}
```
We want the error to hint about the unclosed `<`, not the `}` (which isn't really in the context of the type).

Differential Revision: https://reviews.llvm.org/D141635


  Commit: 20d06c833d833ef6b2d0f519cc4a7998d49a2803
      https://github.com/llvm/llvm-project/commit/20d06c833d833ef6b2d0f519cc4a7998d49a2803
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M mlir/include/mlir/IR/AttrTypeBase.td

  Log Message:
  -----------
  [mlir][NFC] Use explicit ArrayRef construction in OptionalArrayRefParameter

GCC was barfing on template deduction for ArrayRef parameters in
some situations.


Compare: https://github.com/llvm/llvm-project/compare/91063baa437f...20d06c833d83