[all-commits] [llvm/llvm-project] d987fe: [Attributor] Properly repair broken unittest
Johannes Doerfert via All-commits
all-commits at lists.llvm.org
Thu Jan 12 02:24:21 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: d987fe67adb71ac30261fe5b4fe82bdad9405b7a
https://github.com/llvm/llvm-project/commit/d987fe67adb71ac30261fe5b4fe82bdad9405b7a
Author: Johannes Doerfert <johannes at jdoerfert.de>
Date: 2023-01-12 (Thu, 12 Jan 2023)
Changed paths:
M llvm/unittests/Transforms/IPO/AttributorTest.cpp
Log Message:
-----------
[Attributor] Properly repair broken unittest
Reverts 2dc7c7095153822ecd1a8f43aa4c185f9e80cc00 and instead repairs the
unittest properly. The test was broken as that it used references to
dead functions, assumed dead functions could reach code, assumed code
would not be deleted, and did not pre-query all assertion queries.
Arguably, the querry AAs don't make it easy to use them outside the
attributor pipeline, maybe we just should not (or should fix them
pessimistically). For now, the unittest is fixed.
More information about the All-commits
mailing list