[all-commits] [llvm/llvm-project] 5d64ad: [Attributor][FIX] Avoid creating accidental poison...

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Thu Jan 12 02:13:29 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d64ad85446b3edbc0c5bbae97809e28873f3161
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/Attributor.cpp
    M llvm/test/Transforms/Attributor/liveness.ll
    M llvm/test/Transforms/Attributor/value-simplify.ll

  Log Message:
  [Attributor][FIX] Avoid creating accidental poison callees

Back with f3ad8cf00e213 we introduced a bug that caused us to skip
callees when we replace uses. This is not sound since subsequent IR
cleanup will assume replacement has happend. As such we created poison
callees for a long while. The original intend of the check was to
prevent call graph invalidation, however, we now properly check if the
instructions (here the call) are inside the SCC or not.

More information about the All-commits mailing list