[all-commits] [llvm/llvm-project] 3909b6: [flang][NFC] Remove CallBuilder class

jeanPerier via All-commits all-commits at lists.llvm.org
Thu Jan 12 01:16:45 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3909b60a3c87a85518d2846cdd00f6f985e4f7d8
  Author: Jean Perier <jperier at nvidia.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M flang/lib/Lower/ConvertCall.cpp

  Log Message:
  [flang][NFC] Remove CallBuilder class

The methods of CallBuilder do need to belong to a class.
This was made to avoid having to propagate generic lowering context
(converter, symbol mappings, location and StatementContext).

Packaging them together will actually make it harder to share the code
for user and intrinsic elemental lowering (I plan to use C++ CRTP),
and it is also misleading: one could think there is something going
with the class state while lowering the function while there is not
(and there should not be).

Removes the class and turns the methods into static functions.
Add a new CallContext class to solve the argument threading

This contains no functional changes at all.

Differential Revision: https://reviews.llvm.org/D141510

More information about the All-commits mailing list