[all-commits] [llvm/llvm-project] 682d63: tsan: add kBrokenAliasedMetas condition and test

thurstond via All-commits all-commits at lists.llvm.org
Wed Jan 11 10:24:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 682d635aa508860c306deae23766ca5e2575583a
      https://github.com/llvm/llvm-project/commit/682d635aa508860c306deae23766ca5e2575583a
  Author: Thurston Dang <thurston at google.com>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M compiler-rt/lib/tsan/rtl/tsan_platform.h
    M compiler-rt/lib/tsan/tests/unit/tsan_shadow_test.cpp

  Log Message:
  -----------
  tsan: add kBrokenAliasedMetas condition and test

This fills in a gap in the tsan_shadow_test coverage:
it is possible that the meta regions are aliased
(e.g., the heap meta region overlaps the high app meta
region). Indeed, the Aarch64_39 mapping has been
silently broken in this way for quite some time.

This CL checks whether the individual meta regions
(for low/mid/high/heap) overlap. Note that
(!kBrokenAliasedMetas && !kBrokenLinearity) implies
that MemToMeta is invertible; we cannot directly
test MetaToMem because that function does not exist.

Differential Revision: https://reviews.llvm.org/D141445




More information about the All-commits mailing list