[all-commits] [llvm/llvm-project] 296f7f: [GWP-ASan] Fix atfork handlers being installed mul...

[Mitch Phillips via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 296f7fbbb5c48a961aa31b2ffa1d048e6bfbd7a1
      https://github.com/llvm/llvm-project/commit/296f7fbbb5c48a961aa31b2ffa1d048e6bfbd7a1
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M compiler-rt/lib/gwp_asan/platform_specific/guarded_pool_allocator_posix.cpp

  Log Message:
  -----------
  [GWP-ASan] Fix atfork handlers being installed multiple times in tests

We incorrectly install the atfork handlers multiple times in the test
harness, tracked down to the default parameter used by
CheckLateInitIsOK. This manifested in a hang if running the tests with
--gtest_repeat={>=2} as the atfork handler ran multiple times, causing
double-lock and double-unlock, which on my machine hung.

Add a check-fail for this case as well to prevent this from happening
again (it was difficult to track down and is an easy mistake to make).

Differential Revision: https://reviews.llvm.org/D139731