[all-commits] [llvm/llvm-project] f296dc: Reland: "[libc] Templatize str{, n}cmp"

Alex Brachet via All-commits all-commits at lists.llvm.org
Tue Jan 10 07:40:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f296dce763f99beb6c23f05ea8f7480515b5f6a9
      https://github.com/llvm/llvm-project/commit/f296dce763f99beb6c23f05ea8f7480515b5f6a9
  Author: Alex Brachet <abrachet at google.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M libc/src/string/CMakeLists.txt
    M libc/src/string/memory_utils/CMakeLists.txt
    A libc/src/string/memory_utils/strcmp_implementations.h
    M libc/src/string/strcmp.cpp
    M libc/src/string/strncmp.cpp
    M utils/bazel/llvm-project-overlay/libc/BUILD.bazel

  Log Message:
  -----------
  Reland: "[libc] Templatize str{,n}cmp"

This will be used to implement the case insensitive str{,n}casecmp

This was initially reverted because it broke tests on arm platforms.
Unfortunately, it didn't break on my arm machine, but I suspect the
problem was the old comparator returned char and not int.

Differential Revision: https://reviews.llvm.org/D141235




More information about the All-commits mailing list