[all-commits] [llvm/llvm-project] 482898: [GVNSink] Convert tests to opaque pointers (NFC)

Nikita Popov via All-commits all-commits at lists.llvm.org
Tue Jan 10 03:47:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 482898d9e21995d445745c3157ad95410ae32ee2
      https://github.com/llvm/llvm-project/commit/482898d9e21995d445745c3157ad95410ae32ee2
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M llvm/test/Transforms/GVNSink/sink-common-code.ll
    M llvm/test/Transforms/GVNSink/struct.ll

  Log Message:
  -----------
  [GVNSink] Convert tests to opaque pointers (NFC)

Keeping bitcasts in the common_bitcast() test, otherwise sinking
no longer occurs there. GVNSink seems to have a silly cost model
where sinking just the stores is considered non-profitable, but
sinking the stores and bitcasts (which are free...) is profitable.

As this is not a default-enabled pass, and this problem would exist
without opaque pointers as well, I'm not trying to do anything
about this.




More information about the All-commits mailing list