[all-commits] [llvm/llvm-project] 20894a: [lld-macho] Prevent assertions for aliases to weak...

[Paul Kirth via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 20894a478da224bdd69c91a22a5175b28bc08ed9
      https://github.com/llvm/llvm-project/commit/20894a478da224bdd69c91a22a5175b28bc08ed9
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/test/MachO/weak-def-can-be-hidden.s

  Log Message:
  -----------
  [lld-macho] Prevent assertions for aliases to weak_def_can_be_hidden symbols

In https://reviews.llvm.org/D137982 we found that on Mach-O private
aliases could trigger an assert in lld when the aliasee was a
weak_def_can_be_hidden symbol.

This appears to be incorrect, and should be allowed in Mach-O.
Disallowing this behavior is also inconsistent with how ld64 handles
a private alias to weak_def_can_be_hidden symbols.

This patch removes the assert and tests that LLD handles such aliases
gracefully.

Reviewed By: #lld-macho, int3

Differential Revision: https://reviews.llvm.org/D141082