[all-commits] [llvm/llvm-project] ee1be2: [C++20] [Modules] Make placement allocation functi...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Sun Jan 8 18:41:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee1be282241b1253847e663af000f7082b7f03a3
      https://github.com/llvm/llvm-project/commit/ee1be282241b1253847e663af000f7082b7f03a3
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M clang/lib/Sema/SemaLookup.cpp
    A clang/test/Modules/placement-new-reachable.cpp

  Log Message:
  -----------
  [C++20] [Modules] Make placement allocation functions always visible

Close https://github.com/llvm/llvm-project/issues/59601.

This is actually a workaround for the issue. See the comments and the
test for example. The proper fix should make the placement allocation
functions acceptable based on the context. But it is harder and more
complex on the one side. On the other side, such workaround won't be too
bad in practice since users rarely call the placement allocation
functions directly.

So personally I prefer to address such problems in the simpler way.

Reviewed By: royjacobson

Differential Revision: https://reviews.llvm.org/D141023




More information about the All-commits mailing list