[all-commits] [llvm/llvm-project] 570117: [lldb] Remove remaining uses of llvm::Optional (NFC)

[kazutakahirata via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 570117b6a5c8d1bd4e611aa3087794c215753ab7
      https://github.com/llvm/llvm-project/commit/570117b6a5c8d1bd4e611aa3087794c215753ab7
  Author: Kazu Hirata <kazu at google.com>
  Date:   2023-01-07 (Sat, 07 Jan 2023)

  Changed paths:
    M lldb/include/lldb/Breakpoint/BreakpointID.h
    M lldb/include/lldb/Core/SourceLocationSpec.h
    M lldb/include/lldb/Core/ValueObject.h
    M lldb/include/lldb/Core/ValueObjectChild.h
    M lldb/include/lldb/Host/FileSystem.h
    M lldb/include/lldb/Host/linux/Host.h
    M lldb/include/lldb/Symbol/ObjectFile.h
    M lldb/include/lldb/Target/MemoryRegionInfo.h
    M lldb/include/lldb/Target/MemoryTagMap.h
    M lldb/include/lldb/Target/UnixSignals.h
    M lldb/include/lldb/Utility/Diagnostics.h
    M lldb/include/lldb/Utility/SelectHelper.h
    M lldb/include/lldb/Utility/Timeout.h
    M lldb/include/lldb/Utility/UriParser.h
    M lldb/include/lldb/Utility/UserIDResolver.h
    M lldb/source/Core/DumpDataExtractor.cpp
    M lldb/source/Core/IOHandler.cpp
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/source/Plugins/ABI/ARC/ABISysV_arc.h
    M lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h
    M lldb/source/Plugins/Instruction/RISCV/RISCVInstructions.h
    M lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp
    M lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.h
    M lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.h
    M lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h
    M lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
    M lldb/source/Plugins/Process/minidump/MinidumpParser.h
    M lldb/source/Plugins/Process/minidump/MinidumpTypes.h
    M lldb/source/Plugins/SymbolFile/DWARF/DIERef.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.h
    M lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.h
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPTConstants.h
    M lldb/source/Plugins/Trace/intel-pt/TraceIntelPTJSONStructs.h
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
    M lldb/source/Utility/SelectHelper.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/unittests/DataFormatter/StringPrinterTests.cpp
    M lldb/unittests/Process/minidump/MinidumpParserTest.cpp
    M lldb/unittests/tools/lldb-server/tests/TestClient.h

  Log Message:
  -----------
  [lldb] Remove remaining uses of llvm::Optional (NFC)

This patch removes the unused "using" declarations, updates comments,
and removes #include "llvm/ADT/Optional.h".

This is part of an effort to migrate from llvm::Optional to
std::optional:

https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716