[all-commits] [llvm/llvm-project] 3adb0a: [mlir][py] Fix python modules build with clang-cl ...

zero9178 via All-commits all-commits at lists.llvm.org
Fri Jan 6 13:48:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3adb0ac183242cd18931dc0dc011385403727f92
      https://github.com/llvm/llvm-project/commit/3adb0ac183242cd18931dc0dc011385403727f92
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M mlir/cmake/modules/AddMLIRPython.cmake

  Log Message:
  -----------
  [mlir][py] Fix python modules build with clang-cl due to requiring exceptions

The generator expression previously used to enable exceptions would not work since the compiler id of clang-cl is Clang, even if used via clang-cl.

The patch fixes that by replacing the generator expression with simple logic, setting the right compiler flags for all MSVC like compilers (including clang-cl) and all GCC like compilers.

Differential Revision: https://reviews.llvm.org/D141155




More information about the All-commits mailing list