[all-commits] [llvm/llvm-project] c383f4: [DebugInfo] Allow non-stack_value variadic express...

[Stephen Tozer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c383f4d6550e30866294a0e1907a4519245c03eb
      https://github.com/llvm/llvm-project/commit/c383f4d6550e30866294a0e1907a4519245c03eb
  Author: Stephen Tozer <Stephen.Tozer at Sony.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M llvm/docs/MIRLangRef.rst
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
    M llvm/lib/CodeGen/LiveDebugVariables.cpp
    M llvm/lib/CodeGen/MachineFunction.cpp
    M llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/lib/Transforms/Utils/Local.cpp
    M llvm/test/CodeGen/X86/dbg-value-superreg-copy2.mir
    M llvm/test/DebugInfo/COFF/pieces.ll
    M llvm/test/DebugInfo/MIR/InstrRef/accept-nonlive-reg-phis.mir
    M llvm/test/DebugInfo/MIR/InstrRef/dbg-phi-subregister-location.mir
    M llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-in-ldv.mir
    M llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-in-ldv2.mir
    M llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-merging-in-ldv.mir
    M llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-with-loops.mir
    M llvm/test/DebugInfo/MIR/InstrRef/deref-spills-with-size.mir
    M llvm/test/DebugInfo/MIR/InstrRef/follow-spill-of-live-value.mir
    M llvm/test/DebugInfo/MIR/InstrRef/livedebugvalues_illegal_locs.mir
    M llvm/test/DebugInfo/MIR/InstrRef/livedebugvalues_instrref_tolocs.mir
    M llvm/test/DebugInfo/MIR/InstrRef/livedebugvalues_stackslot_subregs.mir
    M llvm/test/DebugInfo/MIR/InstrRef/livedebugvalues_subreg_substitutions.mir
    M llvm/test/DebugInfo/MIR/InstrRef/memory-operand-folding-tieddef.mir
    M llvm/test/DebugInfo/MIR/InstrRef/memory-operand-load-folding.mir
    M llvm/test/DebugInfo/MIR/InstrRef/memory-operand-tracking.mir
    M llvm/test/DebugInfo/MIR/InstrRef/out-of-scope-blocks.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-coalesce-subreg.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-coalescing.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-on-stack-coalesced.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-on-stack-coalesced2.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-regallocd-to-stack.mir
    M llvm/test/DebugInfo/MIR/InstrRef/phi-through-regalloc.mir
    M llvm/test/DebugInfo/MIR/InstrRef/pick-vphi-in-shifting-loop.mir
    M llvm/test/DebugInfo/MIR/InstrRef/spill-slot-limits.mir
    M llvm/test/DebugInfo/MIR/InstrRef/stack-coloring-dbg-phi.mir
    M llvm/test/DebugInfo/MIR/InstrRef/survives-livedebugvars.mir
    M llvm/test/DebugInfo/MIR/InstrRef/win32-chkctk-modifies-esp.mir
    M llvm/test/DebugInfo/MIR/InstrRef/x86-drop-compare-inst.mir
    M llvm/test/DebugInfo/MIR/X86/instr-ref-join-def-vphi.mir
    M llvm/test/DebugInfo/X86/dbg-value-funcarg.ll
    M llvm/test/DebugInfo/X86/dbg-value-funcarg2.ll
    M llvm/test/DebugInfo/X86/dbg-value-funcarg4.ll
    M llvm/test/DebugInfo/X86/dbg-value-list-selectiondag-salvage.ll
    M llvm/test/DebugInfo/X86/debug_value_list_selectiondag.ll
    M llvm/test/DebugInfo/X86/instr-ref-dbg-declare.ll
    M llvm/test/DebugInfo/X86/instr-ref-selectiondag.ll
    M llvm/test/DebugInfo/X86/live-debug-values-expr-conflict.ll
    M llvm/test/DebugInfo/X86/live-debug-vars-loc-limit.ll
    M llvm/test/DebugInfo/X86/pieces-4.ll
    M llvm/test/DebugInfo/X86/pr34545.ll
    M llvm/test/DebugInfo/X86/sdag-combine.ll
    M llvm/test/DebugInfo/X86/sdag-dangling-dbgvalue.ll
    M llvm/test/DebugInfo/X86/sdag-dbgvalue-phi-use-3.ll
    M llvm/test/DebugInfo/X86/sdag-dbgvalue-phi-use-4.ll
    M llvm/test/DebugInfo/X86/sdag-salvage-add.ll
    M llvm/test/DebugInfo/X86/sdagsplit-1.ll
    M llvm/test/DebugInfo/X86/spill-nospill.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/loop-sink.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/lower-to-value.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll
    M llvm/test/DebugInfo/assignment-tracking/X86/sdag-dangling-dbgassign.ll
    M llvm/unittests/IR/MetadataTest.cpp

  Log Message:
  -----------
  [DebugInfo] Allow non-stack_value variadic expressions and use in DBG_INSTR_REF

Prior to this patch, variadic DIExpressions (i.e. ones that contain
DW_OP_LLVM_arg) could only be created by salvaging debug values to create
stack value expressions, resulting in a DBG_VALUE_LIST being created. As of
the previous patch in this patch stack, DBG_INSTR_REF's syntax has been
changed to match DBG_VALUE_LIST in preparation for supporting variadic
expressions. This patch adds some minor changes needed to allow variadic
expressions that aren't stack values to exist, and allows variadic expressions
that are trivially reduceable to non-variadic expressions to be handled
similarly to non-variadic expressions.

Reviewed by: jmorse

Differential Revision: https://reviews.llvm.org/D133926