[all-commits] [llvm/llvm-project] 54fab1: [clang-format] Require space before noexcept quali...

Emilia Dreamer via All-commits all-commits at lists.llvm.org
Thu Jan 5 19:09:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 54fab18cedace085344b674ab9de2c93b5fa479b
      https://github.com/llvm/llvm-project/commit/54fab18cedace085344b674ab9de2c93b5fa479b
  Author: Emilia Dreamer <emilia at rymiel.space>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M clang/lib/Format/TokenAnnotator.cpp
    M clang/unittests/Format/FormatTest.cpp

  Log Message:
  -----------
  [clang-format] Require space before noexcept qualifier

This brings the noexcept qualifier more visually in line with the other
keyword qualifiers, such as "final" and "override".

Originally reported as https://github.com/llvm/llvm-project/issues/44542,
it was closed as "working by design" and reinforcing tests were added
as part of a218706cba90248be0c60bd6a8f10dbcf0270955. The exact spacing
depended on the `PointerAlignment` option, where the default value of
`Right` would leave no space.

This patch seeks to change this behaviour, regardless of the configured
`PointerAlignment` option (matching the previous behaviour of the `Left`
option).

Closes https://github.com/llvm/llvm-project/issues/59729

Reviewed By: HazardyKnusperkeks, owenpan, MyDeveloperDay

Differential Revision: https://reviews.llvm.org/D140767




More information about the All-commits mailing list