[all-commits] [llvm/llvm-project] 69f2b5: Revert an unintentional API ABI break

Adrian Prantl via All-commits all-commits at lists.llvm.org
Thu Jan 5 13:43:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69f2b5fcf1be2226181cce21066f072279ba5d14
      https://github.com/llvm/llvm-project/commit/69f2b5fcf1be2226181cce21066f072279ba5d14
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    M lldb/include/lldb/lldb-enumerations.h

  Log Message:
  -----------
  Revert an unintentional API ABI break

lldb::LanguageType is used as a parameter in
SBExpressionOptions::SetLanguage(), which actually makes this type API
too. Commit 6eaedbb52f2a616e644e5acc7279c8b07c4cfe82 added a
`: uint16_t` to it, which broke binary compatibility for the SBAPI. This
patch reverts to the original enum.

I tried moving the entire enum into include/API, but that created a
cyclic module dependency between API and Utility. To keep things
simple, this just reverts to the original code and adds a warning.

rdar://103415402

Differential Revision: https://reviews.llvm.org/D141087




More information about the All-commits mailing list