[all-commits] [llvm/llvm-project] c25af9: [libc][NFC] Use a function instead of templated st...

Guillaume Chatelet via All-commits all-commits at lists.llvm.org
Thu Jan 5 02:03:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c25af9bb1ea50353e6387d59a13e3c81fb116a74
      https://github.com/llvm/llvm-project/commit/c25af9bb1ea50353e6387d59a13e3c81fb116a74
  Author: Guillaume Chatelet <gchatelet at google.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    M libc/src/stdio/printf_core/CMakeLists.txt
    M libc/src/stdio/printf_core/parser.cpp
    M libc/src/stdio/printf_core/parser.h

  Log Message:
  -----------
  [libc][NFC] Use a function instead of templated static member functions for TYPE_DESC

I'm surprised that clang accepts the current code.
It seems odd to me to specialize templated static member variables.

GCC rejects them: https://godbolt.org/z/3ecE9Ps7T

This patch is in the context of https://github.com/llvm/llvm-project/issues/59368

Differential Revision: https://reviews.llvm.org/D140981




More information about the All-commits mailing list