[all-commits] [llvm/llvm-project] e9c824: [lld-macho][nfc] Re-enable previously disabled test.

Vy Nguyen via All-commits all-commits at lists.llvm.org
Wed Jan 4 09:41:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e9c82423939742ba85c497f16dcac6a547534b67
      https://github.com/llvm/llvm-project/commit/e9c82423939742ba85c497f16dcac6a547534b67
  Author: Vy Nguyen <vyng at google.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M lld/test/MachO/fat-arch.s

  Log Message:
  -----------
  [lld-macho][nfc] Re-enable previously disabled test.

This check was previous disabled because the test kept failing on ARM64. The output from reported failure message
gave the impression that the bundle was created as an x86-64 bundle but upon further inspection, I believe that's
a bug in llvm-otool where it prints both -h and -f for both input files on ARM64.

So the "fix" here is to rewrite the test to run the two otool commands separately but concatenate the
output into one file for checking.

Differential Revision: https://reviews.llvm.org/D140987




More information about the All-commits mailing list