[all-commits] [llvm/llvm-project] e7790f: [mlir] Add `test-convergence` option to Canonicali...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e7790fbed32b729ad59cea4b77d152514605cb0e
      https://github.com/llvm/llvm-project/commit/e7790fbed32b729ad59cea4b77d152514605cb0e
  Author: Matthias Springer <springerm at google.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M mlir/include/mlir/Transforms/Passes.td
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
    M mlir/lib/Transforms/Canonicalizer.cpp
    M mlir/test/Dialect/AMDGPU/canonicalize.mlir
    M mlir/test/Dialect/Affine/canonicalize.mlir
    M mlir/test/Dialect/Arith/canonicalize.mlir
    M mlir/test/Dialect/Bufferization/canonicalize.mlir
    M mlir/test/Dialect/Builtin/canonicalize.mlir
    M mlir/test/Dialect/Complex/canonicalize.mlir
    M mlir/test/Dialect/ControlFlow/canonicalize.mlir
    M mlir/test/Dialect/GPU/canonicalize.mlir
    M mlir/test/Dialect/LLVMIR/canonicalize.mlir
    M mlir/test/Dialect/Linalg/canonicalize.mlir
    M mlir/test/Dialect/Math/canonicalize.mlir
    M mlir/test/Dialect/MemRef/canonicalize.mlir
    M mlir/test/Dialect/OpenACC/canonicalize.mlir
    M mlir/test/Dialect/OpenMP/canonicalize.mlir
    M mlir/test/Dialect/PDL/canonicalize.mlir
    M mlir/test/Dialect/Quant/canonicalize.mlir
    M mlir/test/Dialect/SCF/canonicalize.mlir
    M mlir/test/Dialect/SPIRV/Transforms/canonicalize.mlir
    M mlir/test/Dialect/Shape/canonicalize.mlir
    M mlir/test/Dialect/Tensor/canonicalize.mlir
    M mlir/test/Dialect/Tosa/canonicalize.mlir
    M mlir/test/Dialect/Vector/canonicalize.mlir
    M mlir/test/Pass/run-reproducer.mlir
    M mlir/test/Transforms/canonicalize.mlir

  Log Message:
  -----------
  [mlir] Add `test-convergence` option to Canonicalizer tests

This new option is set to `false` by default. It should  be set only in Canonicalizer tests to detect faulty canonicalization patterns. I.e., patterns that prevent the canonicalizer from converging. The canonicalizer should always convergence on such small unit tests that we have in `canonicalize.mlir`.

Two faulty canonicalization patterns were detected and fixed with this change.

Differential Revision: https://reviews.llvm.org/D140873