[all-commits] [llvm/llvm-project] 3f3b71: llvm-reduce: Try to fix error message test on windows

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jan 3 06:58:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3f3b71ae02af434981a73acced146f4d849a87fc
      https://github.com/llvm/llvm-project/commit/3f3b71ae02af434981a73acced146f4d849a87fc
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    M llvm/test/tools/llvm-reduce/fail-execute-test.test

  Log Message:
  -----------
  llvm-reduce: Try to fix error message test on windows

It seems the execute implementations have gone out of their way to
produce inconsistent error messages. The unix version explicitly
checks if the file exists before trying to execute. The windows
version checks if it's executable. I don't understand why they
wouldn't just try the execution and check the error code.




More information about the All-commits mailing list