[all-commits] [llvm/llvm-project] 4aa776: [bazel] Restore libpfm as a conditional dependency...

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Wed Dec 28 08:13:35 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4aa77690b98e564c598505749d4eb57b9a8be32c
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2022-12-28 (Wed, 28 Dec 2022)

  Changed paths:
    M utils/bazel/.bazelrc
    M utils/bazel/WORKSPACE
    M utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
    A utils/bazel/third_party_build/pfm.BUILD

  Log Message:
  [bazel] Restore libpfm as a conditional dependency for exegesis.

We used to have `pfm` built into exegesis, although since it's an external dependency we marked it as a manual target. Because of this we didn't have buildbot coverage and so we removed it in D134510 after we had a few breakages that weren't caught. This adds it back, but with three possible states similar to the story with `mpfr`, i.e. it can either be disabled, built from external sources (git/make), or use whatever `-lpfm` is installed on the system.

This change is modeled after D119547. Like that patch, the default is off (matching the status quo), but unlike that patch we don't enable it for CI because IIRC we don't have the package installed there, and building from source might be expensive. We could  enable it later either after installing it on buildbot machines or by measuring build cost and deeming it OK.

Reviewed By: GMNGeoffrey

Differential Revision: https://reviews.llvm.org/D138470

More information about the All-commits mailing list