[all-commits] [llvm/llvm-project] 00c784: [InstCombine] replace undef in vector tests with p...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Mon Dec 26 10:37:22 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 00c7840115fb742cd7278a5b3f5337990429ca47
      https://github.com/llvm/llvm-project/commit/00c7840115fb742cd7278a5b3f5337990429ca47
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-12-26 (Mon, 26 Dec 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/canonicalize-low-bit-mask-v3-and-icmp-eq-to-icmp-ule.ll
    M llvm/test/Transforms/InstCombine/canonicalize-low-bit-mask-v3-and-icmp-ne-to-icmp-ugt.ll
    M llvm/test/Transforms/InstCombine/icmp-uge-of-add-of-shl-one-by-bits-to-allones-and-val-to-icmp-eq-of-lshr-val-by-bits-and-0.ll
    M llvm/test/Transforms/InstCombine/icmp-ult-of-add-of-shl-one-by-bits-to-allones-and-val-to-icmp-ne-of-lshr-val-by-bits-and-0.ll
    M llvm/test/Transforms/InstCombine/partally-redundant-left-shift-input-masking-after-truncation-variant-a.ll
    M llvm/test/Transforms/InstCombine/partally-redundant-left-shift-input-masking-variant-a.ll
    M llvm/test/Transforms/InstCombine/redundant-left-shift-input-masking-after-truncation-variant-a.ll
    M llvm/test/Transforms/InstCombine/redundant-left-shift-input-masking-variant-a.ll
    M llvm/test/Transforms/InstCombine/shl-sub.ll

  Log Message:
  -----------
  [InstCombine] replace undef in vector tests with poison; NFC

I left a few of the existing undef tests in place for extra
coverage and because one of those was noted as a miscompile in
the post-commit feedback for d4493dd1ed58ac3f1eab0, but we are
transitioning to poison, so it is more valuable to test the
expected IR going forward.


  Commit: a0c8017286de0cc34db41bfe7ab3176ca4f8ae64
      https://github.com/llvm/llvm-project/commit/a0c8017286de0cc34db41bfe7ab3176ca4f8ae64
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-12-26 (Mon, 26 Dec 2022)

  Changed paths:
    M llvm/include/llvm/IR/Constant.h
    M llvm/lib/IR/Constants.cpp
    M llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
    M llvm/test/Transforms/InstCombine/icmp-uge-of-add-of-shl-one-by-bits-to-allones-and-val-to-icmp-eq-of-lshr-val-by-bits-and-0.ll
    M llvm/test/Transforms/InstCombine/icmp-ult-of-add-of-shl-one-by-bits-to-allones-and-val-to-icmp-ne-of-lshr-val-by-bits-and-0.ll

  Log Message:
  -----------
  [InstCombine] do not add "nuw" to 1<<X if the "1" has undefined elements

This was noted as a potential miscompile in the post-commit feedback
for the patch that added this fold:
d4493dd1ed58ac3f1eab0


Compare: https://github.com/llvm/llvm-project/compare/dfc20708bcdf...a0c8017286de


More information about the All-commits mailing list