[all-commits] [llvm/llvm-project] 23f145: [NFC] Fix leak in command options configuration.

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Thu Dec 8 16:37:57 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2
      https://github.com/llvm/llvm-project/commit/23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M lldb/source/Commands/CommandObjectPlatform.cpp

  Log Message:
  -----------
  [NFC] Fix leak in command options configuration.

`m_options.Append(new OptionPermissions())` leaks because the pointer passed in is not owned. Use a class member to ensure lifetime, which is the common pattern used for this API.

Found by the LLDB command interpreter fuzzer. The fuzz input is running `ap $` twice.




More information about the All-commits mailing list