[all-commits] [llvm/llvm-project] 739611: Revert "[SROA] For non-speculatable `load`s of `se...

[Roman Lebedev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 739611870d3b06605afe25cc07833f6a62de9545
      https://github.com/llvm/llvm-project/commit/739611870d3b06605afe25cc07833f6a62de9545
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M llvm/include/llvm/Transforms/Scalar.h
    M llvm/include/llvm/Transforms/Scalar/SROA.h
    M llvm/include/llvm/Transforms/Utils/BasicBlockUtils.h
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassBuilderPipelines.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/lib/Transforms/Scalar/SROA.cpp
    M llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
    M llvm/test/Transforms/SROA/2009-02-20-InstCombine-SROA.ll
    M llvm/test/Transforms/SROA/address-spaces.ll
    M llvm/test/Transforms/SROA/addrspacecast.ll
    M llvm/test/Transforms/SROA/alignment.ll
    M llvm/test/Transforms/SROA/alloca-address-space.ll
    M llvm/test/Transforms/SROA/assume.ll
    M llvm/test/Transforms/SROA/basictest.ll
    M llvm/test/Transforms/SROA/big-endian.ll
    M llvm/test/Transforms/SROA/dbg-addr-diamond.ll
    M llvm/test/Transforms/SROA/dbg-inline.ll
    M llvm/test/Transforms/SROA/dbg-single-piece.ll
    M llvm/test/Transforms/SROA/dead-inst.ll
    M llvm/test/Transforms/SROA/fca.ll
    M llvm/test/Transforms/SROA/ignore-droppable.ll
    M llvm/test/Transforms/SROA/invariant-group.ll
    M llvm/test/Transforms/SROA/irregular-type.ll
    M llvm/test/Transforms/SROA/lifetime-intrinsic.ll
    M llvm/test/Transforms/SROA/mem-par-metadata-sroa-cast.ll
    M llvm/test/Transforms/SROA/mem-par-metadata-sroa.ll
    M llvm/test/Transforms/SROA/non-capturing-call-readonly.ll
    M llvm/test/Transforms/SROA/non-integral-pointers.ll
    M llvm/test/Transforms/SROA/phi-and-select.ll
    M llvm/test/Transforms/SROA/phi-catchswitch.ll
    M llvm/test/Transforms/SROA/phi-gep.ll
    M llvm/test/Transforms/SROA/phi-speculate-different-load-types.ll
    M llvm/test/Transforms/SROA/phi-with-duplicate-pred.ll
    M llvm/test/Transforms/SROA/pointer-offset-size.ll
    M llvm/test/Transforms/SROA/ppcf128-no-fold.ll
    M llvm/test/Transforms/SROA/pr26972.ll
    M llvm/test/Transforms/SROA/pr37267.ll
    M llvm/test/Transforms/SROA/preserve-nonnull.ll
    M llvm/test/Transforms/SROA/scalable-vectors.ll
    M llvm/test/Transforms/SROA/select-gep.ll
    M llvm/test/Transforms/SROA/select-load.ll
    M llvm/test/Transforms/SROA/slice-order-independence.ll
    M llvm/test/Transforms/SROA/slice-width.ll
    M llvm/test/Transforms/SROA/sroa-common-type-fail-promotion.ll
    M llvm/test/Transforms/SROA/std-clamp.ll
    M llvm/test/Transforms/SROA/tbaa-struct.ll
    M llvm/test/Transforms/SROA/tbaa-struct2.ll
    M llvm/test/Transforms/SROA/tbaa-subload.ll
    M llvm/test/Transforms/SROA/vector-conversion.ll
    M llvm/test/Transforms/SROA/vector-lifetime-intrinsic.ll
    M llvm/test/Transforms/SROA/vector-promotion-different-size.ll
    M llvm/test/Transforms/SROA/vector-promotion.ll
    M llvm/test/Transforms/SROA/vectors-of-pointers.ll

  Log Message:
  -----------
  Revert "[SROA] For non-speculatable `load`s of `select`s -- split block, insert then/else blocks, form two-entry PHI node"

The assertion about not modifying the CFG seems to not hold,
will recommit in a bit.

https://lab.llvm.org/buildbot#builders/139/builds/32412

This reverts commit 03e6d9d9d1d48e43f3efc35eb75369b90d4510d5.
This reverts commit 4f90f4ada33718f9025d0870a4fe3fe88276b3da.