[all-commits] [llvm/llvm-project] 28246b: [mlir][arith] Rename addui_carry to addui_extended

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Wed Dec 7 14:19:03 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 28246b7e759708e8e667cadef11b6a516c258dc6
      https://github.com/llvm/llvm-project/commit/28246b7e759708e8e667cadef11b6a516c258dc6
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
    M mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
    M mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
    M mlir/lib/Dialect/Arith/IR/ArithOps.cpp
    M mlir/lib/Dialect/Arith/Transforms/EmulateWideInt.cpp
    M mlir/test/Conversion/ArithToLLVM/arith-to-llvm.mlir
    M mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir
    M mlir/test/Dialect/Arith/canonicalize.mlir
    M mlir/test/Dialect/Arith/emulate-wide-int.mlir
    M mlir/test/Dialect/Arith/invalid.mlir
    M mlir/test/Dialect/Arith/ops.mlir
    M mlir/test/Dialect/Arith/test-emulate-wide-int-pass.mlir

  Log Message:
  -----------
  [mlir][arith] Rename addui_carry to addui_extended

The goal is to make the naming of the future `_extended` ops more
consistent. With unsigned addition, the carry value/flag and overflow
bit are the same, but this is not true when it comes to signed addition.

Also rename the second result from `carry` to `overflow`.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D139569




More information about the All-commits mailing list