[all-commits] [llvm/llvm-project] c621c1: [Alignment] Use Align in MCStreamer emitZeroFill/e...
Guillaume Chatelet via All-commits
all-commits at lists.llvm.org
Wed Dec 7 06:29:43 PST 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: c621c1a8e81856e6bf2be79714767d80466e9ede
https://github.com/llvm/llvm-project/commit/c621c1a8e81856e6bf2be79714767d80466e9ede
Author: Guillaume Chatelet <gchatelet at google.com>
Date: 2022-12-07 (Wed, 07 Dec 2022)
Changed paths:
M llvm/include/llvm/MC/MCDXContainerStreamer.h
M llvm/include/llvm/MC/MCELFStreamer.h
M llvm/include/llvm/MC/MCSPIRVStreamer.h
M llvm/include/llvm/MC/MCStreamer.h
M llvm/include/llvm/MC/MCWasmStreamer.h
M llvm/include/llvm/MC/MCWinCOFFStreamer.h
M llvm/include/llvm/MC/MCXCOFFStreamer.h
M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
M llvm/lib/MC/MCAsmStreamer.cpp
M llvm/lib/MC/MCELFStreamer.cpp
M llvm/lib/MC/MCMachOStreamer.cpp
M llvm/lib/MC/MCNullStreamer.cpp
M llvm/lib/MC/MCParser/AsmParser.cpp
M llvm/lib/MC/MCParser/DarwinAsmParser.cpp
M llvm/lib/MC/MCParser/MasmParser.cpp
M llvm/lib/MC/MCStreamer.cpp
M llvm/lib/MC/MCWasmStreamer.cpp
M llvm/lib/MC/MCWinCOFFStreamer.cpp
M llvm/lib/MC/MCXCOFFStreamer.cpp
M llvm/lib/Object/RecordStreamer.cpp
M llvm/lib/Object/RecordStreamer.h
M llvm/tools/llvm-exegesis/lib/SnippetFile.cpp
M llvm/tools/llvm-mca/CodeRegionGenerator.cpp
M llvm/unittests/CodeGen/TestAsmPrinter.h
Log Message:
-----------
[Alignment] Use Align in MCStreamer emitZeroFill/emitLocalCommonSymbol
Before performing this change, I checked that `ByteAlignment` was never `0` inside `MCAsmStreamer:emitZeroFill` and `MCAsmStreamer::emitLocalCommonSymbol`.
I believe it is NFC as `0` values are illegal in `emitZeroFill` anyways, `Log2(ByteAlignment)` would be undefined.
And currently, all calls to `emitLocalCommonSymbol` are provably `>0`.
Differential Revision: https://reviews.llvm.org/D139439
More information about the All-commits
mailing list