[all-commits] [llvm/llvm-project] ed7607: [LICM] Remove custom isInstInList() implementation...

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Dec 7 00:51:51 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ed7607417371929c2c3c390c66ea48e908c4d0fa
      https://github.com/llvm/llvm-project/commit/ed7607417371929c2c3c390c66ea48e908c4d0fa
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LICM.cpp
    A llvm/test/Transforms/LICM/pr59324.ll

  Log Message:
  -----------
  [LICM] Remove custom isInstInList() implementation (PR59324)

We already collect all instructions that need to be promoted. The
custom isInstInList() implementation could provide incorrect
results if a new use of the original pointer was introduced as
part of promotion. This probably cannot happen with normal code,
because of the pointer capture, but it can happen with a null
pointer.

Fixes https://github.com/llvm/llvm-project/issues/59324.




More information about the All-commits mailing list