[all-commits] [llvm/llvm-project] b4ce9e: [AMDGPU] Change handling of s_endpgm's optional op...

Jay Foad via All-commits all-commits at lists.llvm.org
Wed Dec 7 00:26:04 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4ce9e9521740a251f1696458ed24b8528c4c67e
      https://github.com/llvm/llvm-project/commit/b4ce9e9521740a251f1696458ed24b8528c4c67e
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SOPInstructions.td

  Log Message:
  -----------
  [AMDGPU] Change handling of s_endpgm's optional operand. NFC.

s_endpgm is a special SOPP instruction in that its operand is optional
and if it is not present then we don't want to print a space after the
mnemonic.

Previously this was handled by defaulting real_name to the mnemonic with
a trailing space, and having s_endpgm override it to be the mnemonic
with no trailing space.

This patch implements a different approach where the separator between
Mnemonic and AsmOperands defaults to a space, but s_endpgm overrides it
to be the empty string.

Differential Revision: https://reviews.llvm.org/D139412




More information about the All-commits mailing list