[all-commits] [llvm/llvm-project] 0c2b7f: Leave DW_OP_addr addresses as load addresses in DW...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c2b7fa8691e9d1f6c7dd656e44321ef8c84ae87
      https://github.com/llvm/llvm-project/commit/0c2b7fa8691e9d1f6c7dd656e44321ef8c84ae87
  Author: Jason Molenda <jason at molenda.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M lldb/source/Expression/DWARFExpression.cpp
    R lldb/test/API/lang/c/high-mem-global/Makefile
    R lldb/test/API/lang/c/high-mem-global/TestHighMemGlobal.py
    R lldb/test/API/lang/c/high-mem-global/main.c

  Log Message:
  -----------
  Leave DW_OP_addr addresses as load addresses in DWARFExpression

DWARFExpression::Evaluate will convert DW_OP_addr addresses in
a DWARF expression into load addresses on the expression stack
when there is a StackFrame in the ExecutionContext, this from
a change in 2018 in https://reviews.llvm.org/D46362.  At the
time this was handling a case that came up in swift programs,
and is no longer necessary.  I generalized this conversion to
a load address when a Target is available in
https://reviews.llvm.org/D137682 to make a test case possible;
this change broke a use case that Ted reported.

This change removes my test case, and removes this conversion
of a DW_OP_addr into a load address in some instances.

Differential Revision: https://reviews.llvm.org/D139226