[all-commits] [llvm/llvm-project] 1127e4: Don't revisit the subexpressions of PseudoObjectEx...

[Akira Hatanaka via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1127e479e85011b4284dd5097ca2732347198130
      https://github.com/llvm/llvm-project/commit/1127e479e85011b4284dd5097ca2732347198130
  Author: Akira Hatanaka <ahatanaka at apple.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M clang/lib/AST/ParentMap.cpp
    M clang/test/SemaObjC/arc-repeated-weak.mm

  Log Message:
  -----------
  Don't revisit the subexpressions of PseudoObjectExpr when building a
ParentMap

The assertion that is removed in this patch was failing when ObjC dot
notation expressions appear in both sides of an assignment (see the test
case in arc-repeated-weak.mm). Visit the PseudoObjectExpr once when the
syntactic expression is visited and return without visiting the
subexpressions when it's visited again when the semantic expressions are
visited.

Differential Revision: https://reviews.llvm.org/D139171